search

ssbc / ssb-server

The gossip and replication server for Secure Scuttlebutt - a distributed social network
1.68k stars 164 forks source link

Error: help command is missing from! #667

Closed christianbundy closed 5 years ago

christianbundy commented 5 years ago

When running Patchwork (ssb-server@14) with the new ssb-server@15 CLI it seems to just throw errors. Not sure how this should be resolved, but if the CLI is totally incompatible maybe we should tell people to upgrade their CLI to match the server version?

$ ssb-server
at command: []
/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:114
      throw new Error('help command is missing from!' + cmd.join('.'))
      ^

Error: help command is missing from!
    at usage (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:114:13)
    at next (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:186:7)
    at module.exports (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:151:5)
    at /home/christianbundy/src/ssbc/ssb-server/bin.js:159:5
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/ssb-client/client.js:78:5
    at next (/home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/compose.js:28:14)
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/compose.js:34:9
    at _cb (/home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/plugins/shs.js:31:11)
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/secret-handshake/protocol.js:122:7
    at Object.cb (/home/christianbundy/src/ssbc/ssb-server/node_modules/secret-handshake/protocol.js:57:11)
$ ssb-server --help
at command: []
/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:114
      throw new Error('help command is missing from!' + cmd.join('.'))
      ^

Error: help command is missing from!
    at usage (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:114:13)
    at module.exports (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:131:29)
    at /home/christianbundy/src/ssbc/ssb-server/bin.js:159:5
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/ssb-client/client.js:78:5
    at next (/home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/compose.js:28:14)
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/compose.js:34:9
    at _cb (/home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/plugins/shs.js:31:11)
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/secret-handshake/protocol.js:122:7
    at Object.cb (/home/christianbundy/src/ssbc/ssb-server/node_modules/secret-handshake/protocol.js:57:11)
    at drain (/home/christianbundy/src/ssbc/ssb-server/node_modules/pull-reader/index.js:39:14)
$ ssb-server friends --help
at command: [ 'friends' ]
/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:114
      throw new Error('help command is missing from!' + cmd.join('.'))
      ^

Error: help command is missing from!friends
    at usage (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:114:13)
    at module.exports (/home/christianbundy/src/ssbc/ssb-server/node_modules/muxrpcli/index.js:131:29)
    at /home/christianbundy/src/ssbc/ssb-server/bin.js:159:5
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/ssb-client/client.js:78:5
    at next (/home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/compose.js:28:14)
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/compose.js:34:9
    at _cb (/home/christianbundy/src/ssbc/ssb-server/node_modules/multiserver/plugins/shs.js:31:11)
    at /home/christianbundy/src/ssbc/ssb-server/node_modules/secret-handshake/protocol.js:122:7
    at Object.cb (/home/christianbundy/src/ssbc/ssb-server/node_modules/secret-handshake/protocol.js:57:11)
    at drain (/home/christianbundy/src/ssbc/ssb-server/node_modules/pull-reader/index.js:39:14)

cc: @dominictarr

dominictarr commented 5 years ago

I am unable to reproduce this on my master, trying npm install ssb-server -g to see what happens

christianbundy commented 5 years ago

This doesn't occur when both the client and server are v15, it only happens when the client is v15 and the server is v14.

On Thu, May 23, 2019, at 07:48, Dominic Tarr wrote:

I am unable to reproduce this on my master, trying npm install ssb-server -g to see what happens

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ssbc/ssb-server/issues/667?email_source=notifications&email_token=AAEDIZB3GP45Y6IXCBOKY53PW2VE5A5CNFSM4HMQVDV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWCO7CA#issuecomment-495251336, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEDIZC7EOTJUGTDJSRV3EDPW2VE5ANCNFSM4HMQVDVQ.

dominictarr commented 5 years ago

okay I fixed muxrpcli to throw a more helpful error if help is completely missing