ssbc / ssb-server

The gossip and replication server for Secure Scuttlebutt - a distributed social network
1.69k stars 164 forks source link

localhost public address (should not be public!) #706

Open dominictarr opened 4 years ago

dominictarr commented 4 years ago

I updated by pub to the latest version, and it's giving an incorrect address for public

> ./bin.js getAddress public
"net:wx.larpa.net:8008~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ=;ws://localhost:9009~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ="

the net address is fine, ws is localhost that's wrong!

previously I was running 14.1.9 and it also returned a slightly weird one, but one that would work "net:wx.larpa.net:8008~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ=;ws://128.199.132.182:9009~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ=" at least the ws address is a real public address here

dominictarr commented 4 years ago

oh my config is:

  "connections": {
    "incoming": {
      "net":[{"scope":"public","transform":"shs","port":8008, "external": "wx.larpa.net", "host": "::"}],
      "ws":[{"scope":"public","transform":"shs", "port":9009}]
    }
  }

so actually external wx.larpa.net on the net address and not the ws is correct!

dominictarr commented 4 years ago

my hunch is ssb-config, since that had recent changes. on the correct version it's 3.2.5 on the incorrect it's 3.3.0

dominictarr commented 4 years ago

oh my ssb-ws was a major version old... so that might be it...

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?