search

ssbc / ssb-server

The gossip and replication server for Secure Scuttlebutt - a distributed social network
1.68k stars 164 forks source link

add ssb-private1 #722

Closed mixmix closed 4 years ago

mixmix commented 4 years ago

with the upcoming ssb-db@20 we're removing the classic private-box functionality by default. To preserve the behaviour state of ssb-server, this adds it back into this distro.

NOTE : this needs ssb-db to be upgraded (once that's published) before merging

mixmix commented 4 years ago

2 errors about getAddress not being a known method ... not sure where that fell off the bandwagon. Having trouble logging stuff

christianbundy commented 4 years ago

I think this is a regression that I caused in https://github.com/ssbc/ssb-db/pull/273

I didn't realize that getAddress() was one of those sneaky inheritance-based methods that appeared out of thin air. :/ I'll open a PR to add it back into SSB-DB.

staltz commented 4 years ago

NOTE : this needs ssb-db to be upgraded (once that's published) before merging

@mixmix could you convert this PR to a "Draft PR" so that we block accidental merges until ssb-db is upgraded?

christianbundy commented 4 years ago

FWIW SSB-DB is upgraded, this branch + test fixes are available here: #724