search

ssbc / ssb-social-index

scuttlebutt plugin for getting reduced state based on the author's social graph
5 stars 2 forks source link

"about" is hardcoded? #7

Open regular opened 2 years ago

regular commented 2 years ago

Here the string 'about' is harcoded. https://github.com/ssbc/ssb-social-index/blob/23beb7f11b02f511d8e7415b250003dc7b7138d6/index.js#L227

Can this be correct? I struggle to use this module for a different purpose (not using "about" as destField). Can this be the cause?

staltz commented 2 years ago

Yeah we should remove the hard coding. It should be using Buffer.from(options.type)