ssbc / ssb-tribes2

SSB private groups with ssb-db2
8 stars 1 forks source link

Test restarting client after getting excluded #101

Closed Powersource closed 1 year ago

Powersource commented 1 year ago

Fixes https://github.com/ssbc/ssb-tribes2/issues/90

socket-security[bot] commented 1 year ago

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Deprecated license ✅ 0 issues
Missing license ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
ssb-box2@7.0.0 6.2.0...7.0.0 None +0/-0
mixmix commented 1 year ago

I love reading nice clear tests.

I don't know what your code changed that means it behaves differently, but it's passing tests so :+1: :heart: :horse:

Powersource commented 1 year ago

the big/only change is in box2/keyring, where we now keep the readKeys and root. we do that because we ran into a bug when adding these tests (specifically when the client was start()ing back up again. the last few tests for list() etc are just for stability/sanity checking, i thought they might be failing but they weren't, so that's nice