search

ssbc / ssb-tribes2

SSB private groups with ssb-db2
8 stars 1 forks source link

Throw out readKeys for a group when we're excluded #103

Open Powersource opened 1 year ago

Powersource commented 1 year ago

We've been doing that but in https://github.com/ssbc/ssb-tribes2/pull/101#discussion_r1176523069 we discovered that that breaks some index/db2 code, so now I'm gonna change it so we just keep readKeys for a group we're excluded from.

Since the readKeys are sent to us in public (in that they're on non-hidden feeds) messages encrypted as DMs to us, it's trivial to find the readKeys again. So this isn't super high priority. But there's no reason to keep them in storage, so we should throw the keys out.

This is a separate issue from https://github.com/ssbc/ssb-tribes2/issues/102. That issue is about deleting the group feeds from the group. But there are group related messages that are not on the group feeds, such as the group feed announce messages, and the member addition messages on the additions feeds. #102 should be done before this issue, since it's both simpler and has a bigger impact.

Powersource commented 1 year ago

The PRs where we start keeping the readKeys (and root) https://gitlab.com/ahau/lib/ssb-keyring/-/merge_requests/26 and https://github.com/ssbc/ssb-box2/pull/32

I think this issue would involve basically reverting those. As well as fixing the index/db2 bug that breaks on suddenly missing readKeys.