People added late to a group should get access to all epochs

[Powersource]

Fixes https://github.com/ssbc/ssb-tribes2/issues/76

• [x] add-member people to all tip epochs
• [x] test that we add to all epoch tips
• [x] test that a late added member can read old stuff
• [x] send added people all old secrets as well
• [x] when joining a group, grab all tip invites (maybe we do already?) and all the secrets in them
• [x] check that we send the right secrets
• [x] update addMembers readme
• [x] did we put/plan to put this in one of the specs? mix? check for issue/task. yeah mix seems to have a task
• [x] add a comment to replicate about it breaking when people have secret feeds from someone else

[Powersource]

interesting error

# create reuses a group feed that hasn't had members yet (because of an earlier crash or something)
ok 17 got root
ok 18 there are no group feeds yet
ok 19 there is 1 group feed after we created a group
ok 20 there is 1 used group feed and 1 we created now with a root message but not ourselves as a member
fail create Error: Failed to add myself to the group when creating a group
    at /home/me/prj/ssb/ssb-tribes2/index.js:100:30
    at /home/me/prj/ssb/ssb-tribes2/index.js:156:29
  Error: todo
    at /home/me/prj/ssb/ssb-tribes2/index.js:156:32
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:109:25
  Error: Failed to resolve epoch @tangle/reduce
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:109:28
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:243:16
  Error: Malformed group/init root message
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:244:11
  Error
    at /home/me/prj/ssb/ssb-tribes2/lib/epochs.js:245:13
    at /home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/ssb-db2@6.3.3/node_modules/ssb-db2/core.js:251:22
    at /home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/ssb-db2@6.3.3/node_modules/ssb-db2/core.js:271:7
    at /home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/ssb-db2@6.3.3/node_modules/ssb-db2/log.js:109:9
    at gotBlock (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/async-append-only-log@4.3.10/node_modules/async-append-only-log/index.js:255:7)
    at getBlock (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/async-append-only-log@4.3.10/node_modules/async-append-only-log/index.js:233:7)
    at get (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/async-append-only-log@4.3.10/node_modules/async-append-only-log/index.js:251:5)
    at waitForLogLoaded (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/async-append-only-log@4.3.10/node_modules/async-append-only-log/index.js:616:12)
    at Object.log.get (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/ssb-db2@6.3.3/node_modules/ssb-db2/log.js:105:5)
    at getMsgByOffset (/home/me/prj/ssb/ssb-tribes2/node_modules/.pnpm/ssb-db2@6.3.3/node_modules/ssb-db2/core.js:269:9)

[Powersource]

was a weird mismatch between create and create tests. made this issue for some other time https://github.com/ssbc/ssb-tribes2/issues/107

[Powersource]

spec update https://github.com/ssbc/private-group-spec/pull/33

[socket-security[bot]]

New dependency changes detected. Learn more about Socket for GitHub ↗︎

---

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Deprecated license	✅ 0 issues
Missing license	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

---

📊 Modified Dependency Overview:

🚮 Removed packages: private-group-spec@7.0.0, ssb-caps@1.1.0

[Powersource]

updated keyring to fix a list() bug https://gitlab.com/ahau/lib/ssb-keyring/-/merge_requests/27

[Powersource]

hmm "publish many messages that might need pruning" is mysteriously freezing sometimes. i think it was happening before we merged the db2 optimization as well (test is gone because re-ran it)

[Powersource]

trying out using normal db2 config like in https://github.com/ssbc/ssb-tribes2/pull/108/files

[Powersource]

@mixmix made change and replied to comments

[Powersource]

oh no there's still flakes :scream:

[mixmix]

@Powersource seems to be flaking on same test with 500 writes

suggestions:

• try skipping the test test.skip
• try setting the options for timeout manually on the test https://github.com/ljharb/tape#testname-opts-cb