search

ssbc / ssb-tribes2

SSB private groups with ssb-db2
8 stars 1 forks source link

Recover by creating a new epoch if someone only posted an exclude message #127

Closed Powersource closed 1 year ago

Powersource commented 1 year ago

Based on https://github.com/ssbc/ssb-tribes2/pull/126

Progresses https://github.com/ssbc/ssb-tribes2/issues/123

Fixes https://github.com/ssbc/ssb-tribes2/issues/30

mixmix commented 1 year ago

OK, have split this into two PRs to simplify debugging:

  1. https://github.com/ssbc/ssb-tribes2/pull/129 : passing
  2. https://github.com/ssbc/ssb-tribes2/pull/130 : contains bugs
Powersource commented 1 year ago

@mixmix is #130 the same as this PR now?

Powersource commented 1 year ago

tests passing now (just linter failing). mostly since we disabled recovery in most tests, so, limited knowledge gained. wondering if we should just merge and see how this fares in the demo app. the situations we're testing just get more and more complex :sweat: :shrug:

Powersource commented 1 year ago

demo app mostly working now, gonna try this branch out

Powersource commented 1 year ago

Doesn't seem to break stuff a lot but there's this bug that pops up (i think unrelated to this PR) that probably stops the code in this PR from running at all https://github.com/ssbc/ssb-tribes2-demo/issues/7

Powersource commented 1 year ago

@mixmix see #135 where i (using the demo) tested this PR together with #134 that allows the code in this PR to get run (i think?). doesn't seem to break stuff, so i'd argue we just merge this and maybe polish more later

mixmix commented 1 year ago

Fresh review (in progress)