search

ssbc / ssb-tribes2

SSB private groups with ssb-db2
8 stars 1 forks source link

Only do tangle `previous` pruning iff the message is actually too big #25

Open Powersource opened 1 year ago

Powersource commented 1 year ago

Being added in this PR https://github.com/ssbc/ssb-tribes2/pull/19

https://github.com/ssbc/ssb-tribes2/blob/da29c04ca432452778ceb55cad0b1f1e88d390f8/lib/prune-publish.js#L8-L9

Right now we assume that create errors because the message is too big, but that's something we could check, like mix says:

we could actually check the error message includes "Too large" or something

staltz commented 1 year ago

@Powersource Can we close this?

Powersource commented 1 year ago

No

staltz commented 1 year ago

@Powersource what's missing? I see PR #19 merged.

Powersource commented 1 year ago

This issue is because #19 was merged. Right now we do pruning whether or not the message is too big. If we add a check that the error is specifically because the message is too big or not, then we could error faster when it didn't error because of the size.

staltz commented 1 year ago

Okay, thanks