search

ssbc / ssb-tribes2

SSB private groups with ssb-db2
8 stars 1 forks source link

Re-addition add-member messages should be published on the additions feed instead #79

Closed Powersource closed 1 year ago

Powersource commented 1 year ago

Nice optimization to have them on the old epochs, in theory, but it increases complexity that we can't handle right now. Doing it this way will fix 2 issues:

  1. Can't re-add people to a new epoch if they haven't posted to the old epoch, since triangulation fails. Found here https://github.com/ssbc/ssb-tribes2/pull/78#discussion_r1147598540
  2. There's a bug in box2 where triangulation fails if you create your feed after you find the other person's. If we just rely on the additions feed (which we create as soon as possible) this should fix itself https://github.com/ssbc/ssb-tribes2/pull/78#discussion_r1151200636
Powersource commented 1 year ago

also related https://github.com/ssbc/ssb-tribes2/pull/78#discussion_r1151200636

Powersource commented 1 year ago
  1. hopefully doesn't even bite us in prod, since people should only replicate additions feeds once we replicate metafeeds, and people will probably only do that once they themselves have groups/metafeeds and therefore called start() and have their own additions feed
Powersource commented 1 year ago

85 seems to have fixed all the issues in #78

@mixmix you might be unblocked already. if not then you might have to wait for #78