search

ssbc / ssb-tribes2

SSB private groups with ssb-db2
8 stars 1 forks source link

Adapt listMembers to exclusion and test it #95

Closed Powersource closed 1 year ago

Powersource commented 1 year ago

Fixes https://github.com/ssbc/ssb-tribes2/issues/77

socket-security[bot] commented 1 year ago

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Deprecated license ✅ 0 issues
Missing license ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
pull-flat-merge@2.0.3 None +0 nichoth

🚮 Removed packages: ssb-crut@4.6.3

Powersource commented 1 year ago

"request review" meaning more like i have questions pls reply

mixmix commented 1 year ago

@Powersource I merged my refactor in (after putting README in, and the shape of the data coming out of listMembers) I also pulled all the listening functions that were running in start() out into ./listeners.js (see comment below)

mixmix commented 1 year ago

Finally... I found a limitation which is causing that test to fail. Solution in this PR : https://github.com/ssbc/ssb-tribes2/pull/112

Powersource commented 1 year ago

who's even reviewing this anymore lol? i'll just merge now lmao