Minecraft 1.20.4
Fabric 0.15.3
Fabric API 0.91.3
Java 20.0.2
Scriptor 1.0.6
BUGS:
Chalk sometimes don't render when placed on the ground. Though it gets fixed and renders after a restart, the issue still sometimes occurs when trying to place new ones.
This next issue occur when trying to interact with a failed, nested-like Chalk Circle. This was discovered by a friend during a LAN session earlier when he attempted to create a nested-like Chalk Circle similar to the picture below. When he tried to interact with it, the spell failed, resulting in a massive lag spike, bombarding sounds and huge amount of particles.
In fabric, you can make the patchouli_book loot table load only if Patchouli is installed by adding fabric:load_conditions to the patchouli_book loot table. This ensures that the loot table will only load if Patchouli is installed in your game, thereby eliminating the error in the logs: [16:40:38] [Worker-ResourceReload-10/ERROR]: Couldn't parse element loot_tables:scriptor:patchouli_book - Unknown registry key in ResourceKey[minecraft:root / minecraft:item]: patchouli:guide_book. The advancement still works tho without the loot table being loaded when Patchouli is not installed.
Just committed some fixes based on these reports, thank you. Marked you as a Co-Author for the third fix since I directly used code you included. Thank you again for reporting!
Mod Version (e.g. Fabric 0.3.4):
Minecraft 1.20.4 Fabric 0.15.3 Fabric API 0.91.3 Java 20.0.2 Scriptor 1.0.6
BUGS:
Chalk
sometimes don't render when placed on the ground. Though it gets fixed and renders after a restart, the issue still sometimes occurs when trying to place new ones.This next issue occur when trying to interact with a failed, nested-like
Chalk Circle
. This was discovered by a friend during a LAN session earlier when he attempted to create a nested-likeChalk Circle
similar to the picture below. When he tried to interact with it, the spell failed, resulting in a massive lag spike, bombarding sounds and huge amount of particles.In fabric, you can make the
patchouli_book
loot table load only ifPatchouli
is installed by addingfabric:load_conditions
to thepatchouli_book
loot table. This ensures that the loot table will only load ifPatchouli
is installed in your game, thereby eliminating the error in the logs:[16:40:38] [Worker-ResourceReload-10/ERROR]: Couldn't parse element loot_tables:scriptor:patchouli_book - Unknown registry key in ResourceKey[minecraft:root / minecraft:item]: patchouli:guide_book
. The advancement still works tho without the loot table being loaded when Patchouli is not installed.