cannot add search engines into firefox, or reset addon's own engine list - firefox 78.0.1

ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers

337 stars 37 forks source link

cannot add search engines into firefox, or reset addon's own engine list - firefox 78.0.1 #263

Closed sign-in-smth closed 4 years ago

sign-in-smth commented 4 years ago

hi,

i just noticed, in this new firefox 78.0.1, i can no longer add engines into firefox's list in the search bar. using the 'Add to ContextSearch' menu option on input elements, i can only succeed in adding engines to the addon's own list, but not into firefox. (examples: https://www.bing.com/, https://torrentz2.is/)

secondly, the addon's own list in ContextSearch options -> Search Engines seems to have some new problems too:

Restore Defaults button no longer works;
Select file... option to load search.json.mozlz4 no longer works. in order to get the addon's engine list to match firefox's list i had to reinstall the addon (but that didn't fix any of the above issues).

also, i saw something related to search engines in firefox changelog here: https://www.mozilla.org/en-US/firefox/78.0.1/releasenotes/ any chance it somehow affected/broke things in your addon too?

thanks, your biggest fan since 2017 :)

sign-in-smth commented 4 years ago

yeh, but because Basic mode is not at 100% since it cannot see which engines might be currently unchecked in FF (that what you said is stored in prefs.js) i may still have to disable it, i'm not sure yet, so i'd have to use Restore Defaults like before.

ssborbis commented 4 years ago

yeh, but because Basic mode is not at 100% since it cannot see which engines might be currently unchecked in FF (that what you said is stored in prefs.js) i may still have to disable it

Could you delete the engines you don't use ( unchecked ) from FF search?

sign-in-smth commented 4 years ago

not always, but i realized i could still keep Basic mode on most of the time, only switch into normal momentarily to do the checking/unchecking it can't handle, then right back into Basic, thus never to touch Restore Defaults. and so no need for the auto-hide options.

do you think mozilla will add the API to read the enabled/disabled status of engines?

ssborbis commented 4 years ago

not always, but i realized i could still keep Basic mode on most of the time, only switch into normal momentarily to do the checking/unchecking it can't handle, then right back into Basic, thus never to touch Restore Defaults. and so no need for the auto-hide options.

If that works for you, that would save me a lot of coding.

do you think mozilla will add the API to read the enabled/disabled status of engines?

I don't know if anyone has brought this up to them. It seems like it would be easy to add the property to the search API, but I haven't looked through the Firefox code. I'll dig around when I have some time.

ssborbis commented 4 years ago

why selecting multiple engines in CS manager, and choosing Delete, doesn't work?

This change is in the repo with some other improvements to the search engine manager and will be in the next release

ssborbis commented 4 years ago

I think this is all (mostly?) addressed in v1.25. Go ahead and open a new issue if anything else needs addressing.