ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
349 stars 37 forks source link

Quick menu opens over youtube window #482

Closed bottleblue closed 2 years ago

bottleblue commented 2 years ago

If the mouse cursor is over the youtube window and I hold right mouse button the quick menu opens even though nothing is highlighted. This is particularly annoying when tab scrolling with right mouse button and mouse wheel from another tab back to the youtube tab. Is there any way to disable this behavior?

Using Firefox 99.01

ssborbis commented 2 years ago

Images, links, videos, etc are considered content that will open the quick menu if one of the opening methods is used.

If you don't use the qm on links or images, you can disable those checkboxes ( or just one if you know which is causing issues ) under CS Options -> Quick Menu

If you simply don't want the qm to ever open on youtube.com, you can add youtube.com to the blocklist under CS options -> General -> Blocklist, or enable the Blocklist tool in the Quick menu and click that to add the current domain to the list.

bottleblue commented 2 years ago

I had the Quick Menu options "Enable on Links" and "Enable on Images" already unchecked. I don't want to block all of youtube because of course there might be text I want to search.

ssborbis commented 2 years ago

The checkboxes only work on the preview videos I guess.

I'm assuming you're using the hold to open method? The simplest thing would be to add an option to cancel opening on mousewheel events.

bottleblue commented 2 years ago

Yea I'm using hold to open. That probably would be the simplest thing. Or maybe disable searching on video window since it doesn't seem to do anything useful

ssborbis commented 2 years ago

Or maybe disable searching on video window since it doesn't seem to do anything useful

I might be able to add video alongside the checkboxes links and images. As for useful, since adding the app launcher, you can do any number of things with a video link. Even a blob might be useful, combined with some javascript.

bottleblue commented 2 years ago

I guess I should say it doesn't do anything useful for me hehe.

ssborbis commented 2 years ago

Changes in the development branch.

Hidden advanced option quickMenuCancelOnMousewheel. You'll need to use the manual edit button to change the setting ( top-right under the Advanced menu )

ssborbis commented 2 years ago

I should probably set the default to on, because I can't think of any reason why anyone would want the qm to open while using the mousewheel.

bottleblue commented 2 years ago

Great how do I download from the development branch?

I guess I can't? You were just letting me know you did the changes?

ssborbis commented 2 years ago

I'm signing a beta now. I'll link you in a sec

ssborbis commented 2 years ago

https://github.com/ssborbis/ContextSearch-web-ext/releases/download/v1.40b1/contextsearch_web_ext-1.40b1-an+fx.xpi

ssborbis commented 2 years ago

You shouldn't have to change any settings. quickMenuCancelOnMousewheel is on by default

bottleblue commented 2 years ago

Hmm it doesn't work. I still get quick menu popups

ssborbis commented 2 years ago

Are you using an extension to do the tab scrolling?

bottleblue commented 2 years ago

Yea it's the Gesturefy extension.

Gesturefy options > Extras > Wheel Gesture - On, Wheel Gesture mouse button - Right, Wheel Up - Focus Left Tab, Wheel Down - Focus Right Tab

I hope this doesn't make it a lot harder to fix :/

ssborbis commented 2 years ago

That extension is probably capturing the scroll event. Can you try this? Open a youtube video without other tabs open, and try to long-click to open the qm. Then try to long-click, but also scroll the wheel. Does it still open?

bottleblue commented 2 years ago

Both long-clicking and long-clicking and wheel scrolling open the menu.

ssborbis commented 2 years ago

Yeah, that's a problem. I'll have to get back to you on this one.

bottleblue commented 2 years ago

K thx for looking into it

ssborbis commented 2 years ago

I have a workaround.

I added an option to close the qm if the tab changes. That should get you the results you want.

bottleblue commented 2 years ago

Great I'll try it and let you know if it works. Thx!

ssborbis commented 2 years ago

https://github.com/ssborbis/ContextSearch-web-ext/releases/download/v1.40b2/contextsearch_web_ext-1.40b2-an+fx.xpi

Audio / video options added alongside links / images CS Options -> Advanced -> Manual edit button -> set quickMenuCloseOnTabChange: true

bottleblue commented 2 years ago

quickMenuCloseOnTabChange doesn't seem to do anything by itself. I still get the qm popup over youtube window. Disabling audio/video option works though and does so whether or not I have quickMenuCloseOnTabChange enabled.

Something else I forgot to mention is that when text is highlighted (when I only want to copy the text) and I scroll to another tab and then back to the tab with the highlighted text it opens the quickmenu. Basically the same problem as the youtube window. It would be awesome if you could make an option to deselect text when scrolling to another tab.

ssborbis commented 2 years ago

quickMenuCloseOnTabChange doesn't seem to do anything by itself

It should close the qm in the window you initially used hold right mouse + scroll to change tabs. It's working for me as intended.

  1. open youtube and play a video
  2. hold right-mouse + scroll to change tabs using Gesturefy

The qm would be triggered to open on the youtube page, but because I changed tabs, it's closed.

Are you not seeing this behavior?

bottleblue commented 2 years ago

Ah I see. Yes if I keep the right mouse button held down and scroll tabs back and forth then it doesn't open the qm again. But if I scroll to the non-youtube tab and let go of the right mouse button then click right mouse button to scroll back to youtube window it still opens the qm. This isn't a problem though since you included the options to disable qm on audio/video. I have no need to search video windows using qm so it's fine.

ssborbis commented 2 years ago

I am seeing the qm open at times when it shouldn't using this workaround. I'll try a few things and see if I can't get more consistency.

bottleblue commented 2 years ago

ok but I consider the youtube problem solved b/c of the audio/video options so thank you for that. If you can also solve the text selection issue that would be amazing. (I hope I'm not being too nitpicky with my issues.)

bottleblue commented 2 years ago

I tested the latest beta build 1.40b3 and quickMenuCloseOnTabChange seems to be working properly. I haven't had any popup issues with youtube or with the highlighted text tab scroll. Looks good thanks!