ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
330 stars 37 forks source link

[Request] Request to add Quick Menu Closing Option #509

Closed lucky80 closed 2 years ago

lucky80 commented 2 years ago

Hello, I'm using this add-on very usefully. Thank you.

I have a request, so I'm leaving this message.

After searching for a specific word in a search engine, block it, modify it to another word, and then press Enter to search.

However, when I pressed Enter for search, the quick menu that was shown disappears, and I have to press Enter one more time to search.

In other words, it's uncomfortable to press Enter twice.

Therefore, I would like to request the addition of the menu 'if keyboard input' to the closing option of the Quick Menu.

Also, it would be useful if there is an option that automatically closes after the set time after the quick menu opens.

Once again, thank you for the good program.

Cap 2022-07-19 16-36-13-071 .

7peanuts commented 2 years ago

Hmm… which part needs to be searched by pressing Enter?

If you want to keep the menu open, you can set these two options and use Esc or mouse wheel to close it.

20220719180202

ssborbis commented 2 years ago

What method are you using to open the quick menu? Auto?

Is the problem that, when you select text in the searchbar on a webpage, the qm opens and you have to press Enter to get rid of it?

If so, you could:

  1. disable the qm from opening on input elements ( CS Options -> Quick Menu -> Enable On -> uncheck input
  2. hold a modifier key down before you release the left mouse button while selecting ( alt, ctrl, shift, whatever ), and the menu shouldn't open.

If it's something else, please explain a bit more. If you're able to make a GIF and post, that would also be helpful. There are so many ways this addon can be configured, I may not be seeing the same things you are.

I'm confused about what you said here:

when I pressed Enter for search, the quick menu that was shown disappears

For me, pressing Enter initiates a search with the first engine in the list when the quick menu is open. Is that not happening in your case? ESC is the key I use to close the menu.

lucky80 commented 2 years ago

First of all, thank you for your reply.

I'll write it in more detail.

After I search in the search text box, I want to change the text on the same site result screen.

Usually, when I want to search again, I double-click the word I searched for, specify the block by dragging, specify the block, and then enter another text.

With the above block designation, the Quick Menu will continue to pop up when I write the word to search, and when I type in the text and press the Enter key to search, the Quick Menu will disappear. And what I'm trying to do is I'm trying to search for the words that I typed, and even though I typed the enter key, only the quick menu disappears.

In that situation, I have to press the enter key one more time to search for the search engine.

The above case can also be reproduced on https://github.com/. After searching for a specific word through the search text box, double-click or drag the word in the text box to search for another word on the search results page, modify it to another word, and type the enter key, and the quick menu is closed. The action I want is to search right away with the enter key.

This phenomenon only appears at certain sites. It is not reproduced on Google site. But it's reproduced in github.

Please refer to the attached capture gif of this phenomenon.

Of course, I know it's possible to disable the Quick Menu in the input text box. I also know that if you enter the ESC key, the quick menu disappears. However, I can't turn off the function because I often search other sites through the Quick menu even the words I typed in the text box.

In other words, the following is a brief summary of what I want.

  1. It would be great if [Close menu by input any key] function was added to the closing option in the quick menu.
  2. I would like to add a function that automatically closes after a set time (e.g., 3 seconds) after opening the quick menu.

I'm using a great add-on program really well. Thank you so much for making such a program.

However, there is a slight inconvenience when using it, so I am writing like this.

This article is written through a translator, so there may be some strange parts. Please excuse me.

Have a nice day Honeycam 2022-07-20 04-08-18 .

ssborbis commented 2 years ago

Thanks for the additional details.

I think I actually already have an option for this. Try CS Options -> Advanced -> Manual Edit button -> quickMenuCloseOnEdit = true

ssborbis commented 2 years ago

I coded a closeOnKeydown before I noticed the old option. If it doesn't work for you, I'll keep the new option to try. I'm pretty sure that option is in the last release???

lucky80 commented 2 years ago

It's solved!

Previously, I searched hard to see if there was such a function in the Advanced option and tested it by changing it one by one, but there was that function in the Manual Edit.

Thank you very much for your reply.

I installed this add-on first on every PC I use and am using it.

Have a good day!

ssborbis commented 2 years ago

No prob

lucky80 commented 2 years ago

Hello. I left a message that the issue that I left last time has been resolved.

I'm leaving a comment again because I don't think it's completely solved yet.

There is no problem if I specify a word by double-clicking when I specify a block, but if I drag and specify a block, the quick menu does not disappear when entering the key.

I am writing again to see if you can correct this part.

Have a nice day.