ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
329 stars 37 forks source link

[BUG] Access key for the ContextSearch Menu doesn't Work? #526

Closed runningcheese closed 2 years ago

runningcheese commented 2 years ago
  1. The Access key for the ContextSearch Menu seems not working?
iShot2022-08-05 10 20 55

and nothing happen here.

iShot2022-08-05 10 17 12
  1. is it possible to make a hotkey combine with modifier key, such as "ctrl+alt+o" to launch chrome browser.
iShot2022-08-05 10 19 50

Thanks in advance.

ssborbis commented 2 years ago

It looks like the access key only works when NOT using the contextual layout. I'll see about adding it. The context menu gets a bit messy when there are multiple contexts for the current selection ( possibly submenus like PAGE, LINK, etc ).

is it possible to make a hotkey combine with modifier key, such as "ctrl+alt+o" to launch chrome browser.

Not currently. In this addon's backend code, there's a distinction between shortcuts ( keys + modifiers ) and hotkeys ( keys only ). Currently, hotkeys intended to launch search engines, or in this case, app engines, are a single key only. It may take substantial work to allow key + modifier (shortcuts) to be used. I'll look into it, but no promises.

runningcheese commented 2 years ago

Thanks for your kind reply! @ssborbis

ssborbis commented 2 years ago

I'm going to reopen this issue so I don't forget. I'll close it when I get a fix into the repository.

ssborbis commented 2 years ago

Please try https://github.com/ssborbis/ContextSearch-web-ext/releases/download/v1.42rc1/contextsearch_web_ext-1.42rc1.xpi

runningcheese commented 2 years ago

Wonderful! But the access key should move to the right side.

iShot2022-08-07 10 30 08
ssborbis commented 2 years ago

But the access key should move to the right side.

Oh, is that the common standard? If so, I'll move it. I've never really taken notice.

runningcheese commented 2 years ago

Oh, is that the common standard? If so, I'll move it. I've never really taken notice.

Yes! Page, Link, Selection, Image, Frame, all the same.