ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
329 stars 37 forks source link

1.42.2 Context Menu search the entire folder Bug #538

Closed 7peanuts closed 1 year ago

7peanuts commented 2 years ago

Unable to save the Search Entire Folder option.

When there are multiple search engines in a folder that use different elements, using Search All will open all search engines, not just the ones shown in the right-click menu.

If the search element is not text, such as an image or a link, then will get blank search terms.

This problem occurs on Chromium, where the option can be saved on Firefox, but it doesn't show up in the context menu.

-gif-2

ssborbis commented 2 years ago

Looks like there are several separate issues happening here. I have some fixes posted to the development branch for testing.

ssborbis commented 2 years ago

See if this is fixed in new release 1.43

7peanuts commented 2 years ago

V1.43

Unable to save the Search Entire Folder option on FF, maybe. Chrome works well.

On Chromium 86.0.4240.198, I don't get a response when I copy Google Site Search, but I end up with a lot more duplicate engines, and cannot delete them.

This problem has occurred once a long time ago, and it has happened again today.

-gif

I imported the configuration into another browser and was unable to remove these duplicate engines.

Here's the file I'm having trouble with.

CSOptions_2022-08-27.zip

Can I delete them directly on the quick menu?

ssborbis commented 2 years ago

Can I delete them directly on the quick menu?

You should be able to if you enable allowDeleteEnginesFromTileMenu and use the layout editor tool to edit the menus. Then drag the tiles to the X that should be at the bottom of the menu.

7peanuts commented 2 years ago

You should be able to if you enable allowDeleteEnginesFromTileMenu and use the layout editor tool to edit the menus. Then drag the tiles to the X that should be at the bottom of the menu.

It's no use. It's still there after refresh.

And these extra engines cannot be searched.

I remember you said that you can choose which engines to import when importing. #490

but on import, you were able to check boxes for what parts you wanted plus a replace / merge option?

Thank you. I solved it. I opened the json file and deleted the extra engines. 😭

ssborbis commented 2 years ago

That will work. I'm looking into the root issue now. I should have a fix for the next release.

Thanks for the bug report

7peanuts commented 2 years ago

v1.43 Don’t know why the search all can’t work anymore.

-gif-

ssborbis commented 2 years ago

That's odd. I just tested on FF and Chromium, and it's working. Is it the same for all folders / engines?

ssborbis commented 2 years ago

I checked again. It's failing on PAGE and FRAME contexts. I'll take a look.

ssborbis commented 2 years ago

Possible fix in the development branch