ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
354 stars 37 forks source link

Engine filtering problem again #547

Closed StrollStars closed 2 years ago

StrollStars commented 2 years ago

It's a bit similar to #537, but it's too complicated to discuss, so I'm opening a new one. 1.Are there some duplications between Context Menu and Quick Menu? I haven't figured out the difference yet. 2.Search Engines → Edit:

Display this engine when opening menus from the selected contexts. Works with Context and Quick menus when Advanced -> Filter Engines is enabled, otherwise ignored.

I only checked selection in one search engine, and unchecked all others, but it didn't have any effect, and other search engines were still there after the text was selected.

ssborbis commented 2 years ago

What menu is having problems? Both?

I only checked selection in one search engine, and unchecked all others,

I'll have to look, but unchecking all might default to "selection" in some cases.

ssborbis commented 2 years ago

Using the latest code and a new profile, things seem to be working as expected. Admittedly, the qm gets a bit weird with 1 engine. I couldn't screenshot the context menu, but it also displayed only the one engine.

1 2 3

4

ssborbis commented 2 years ago

If you have similar settings to what I screenshot and it's still not working correctly, you might send me your config and I'll take a closer look.

StrollStars commented 2 years ago

Thank you for your help. After checking Filter search engines based on the target element(link, image, selection, ...), the expected effect is achieved. However, the instructions in the settings interface need to be updated.

ssborbis commented 2 years ago

However, the instructions in the settings interface need to be updated.

Do you mean this ? Screenshot_2022-09-10_18-52-49

StrollStars commented 2 years ago

I'm sorry, I didn't read carefully, you're right.