ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
329 stars 37 forks source link

[BUG - QM] Search terms in text field are not passed to search engines with double/triple click via "Auto" opening method #557

Closed Fanolian closed 1 year ago

Fanolian commented 1 year ago

Steps to reproduce

  1. In a new Firefox profile, install ContextSearch 1.43 to 1.44.1.
  2. In Context Search's options > Quick Menu > General, enable Input. In Openings, enable Auto (modifier keys are irrelevant; all can reproduce the bug)
  3. Open a webpage with a text field, e.g. https://www.google.com/search?q=test
  4. Double click (with modifiers) a word in the text field to highlight it.
  5. Click any search engine in Quick Menu.

Actual result

The highlighted word is not passed to the search engine. The search engine loads whatever stated in Form Path instead. If I enable the search bar in Quick Menu (and reload the page), it shows that nothing is parsed to the search bar after double clicking.

Expected result

I can preform a search.

Additional notes

  1. With Auto opening method, only double/triple clicking is affected. I can perform a search with click-and-drag to highlight a word (in 1.44/1.44.1; not in 1.43).
  2. I can double/triple click a word, dismiss the auto-popup Quick Menu (via close menu button or click outside Quick Menu), then hold right-click to invoke a new Quick Menu to perform a search.
  3. Double/Triple clicking works outside text fields.

Regression

The bug occurs since 1.43.

Tested browsers

Firefox 104.2 Firefox Nightly (currently 2022-09-13 20220913213020 build)

Thank you for your extension.

ssborbis commented 1 year ago

I am seeing this bug inconsistently. I'll post again when I find out more.

ssborbis commented 1 year ago

Potential fix in 1.44.2 should be live now

Fanolian commented 1 year ago

Fixed in 1.44.2. Thanks.