ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
321 stars 36 forks source link

[BUG] 1.46.4 sometimes can't save the engine parameters #609

Closed 7peanuts closed 10 months ago

7peanuts commented 1 year ago

I saved it several times before it succeeded. Windows 11 22H2 22621.819 Chromium

-gif-1

ssborbis commented 1 year ago

I've noticed this too, but not consistently enough to track down the cause.

ssborbis commented 1 year ago

Also, this may not be an issue after the next release. There are some significant backend changes that could make that bug go away. I haven't seen it while on the newest local code.

logusergithub commented 1 year ago

I also confirm, thanks (Win 10 21H2 - Firefox 107). I thought it was a problem limited to me having many search engines. If it helps, as I am currently adding some engines, these are the steps:

The first save does not keep the parameters entered, the second one does. From my experience it seems to me that it is limited to when you add (or in the case of the video you copy) a new engine. Since I had no idea until a few days ago how powerful 'Add to ContextSearch' was (it adds engines even with post parameters), I am also modifying the parameters of some old existing engine and so far the first save seems to works.

PS: I love the new 'save and close'

ssborbis commented 1 year ago

PS: I love the new 'save and close'

Thanks. Long overdue.

Next release has cut / paste to move engines around easier on long lists

simonbcn commented 1 year ago

Same problem on Brave on Linux. extension version: 1.46.12

ssborbis commented 1 year ago

I was hoping this got fixed with some updated code, but I've seen it too. I think the problem has to do with keeping the options page open in a background tab while interacting with CS menus, but I haven't gotten the bug consistently enough to check. I'll take another look now and see if anything stands out.

ssborbis commented 1 year ago

I just pushed a possible fix to the master branch. Give it a try if you can normally get the bug to happen.

ssborbis commented 12 months ago

v1.46.14 going up

ssborbis commented 10 months ago

I think I finally tracked this issue down for good in 1.46.20. Reopen if you find otherwise, but it looks to be fixed.