ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
354 stars 37 forks source link

Quick menu gets a gap on the right side when icon folder is created #618

Closed sojusnik closed 1 year ago

sojusnik commented 1 year ago

As you can see in the following picture, the quick menu will get a gap on the right side, if an icon folder with two or more search engines inside will be created: grafik

To reproduce this bug:

  1. Restore to defaults the search engines and the settings (in the advanced menu).
  2. Adjust Maximum number of rows to display on opening (grid view) to 4 in the quick menu settings.
  3. Watch this screencast.

This issue appeared after an update a long time ago, maybe half a year or so. Couldn't reproduce it until now.

Happens with v1.46.4 on Firefox 109.

ssborbis commented 1 year ago

Thanks for the detailed report. I think I've found the problem. I'll do some testing to see if the fix breaks anything else then I'll look into getting a patch.

ssborbis commented 1 year ago

I think a fix for this is in the current Master branch and should be in the next release.

sojusnik commented 1 year ago

I think a fix for this is in the current Master branch and should be in the next release.

I just wanted to let you know that this issue is still there in the latest versions.

ssborbis commented 1 year ago

Hmm... I can't trigger that bug any more using your demonstration video. Could you send me a config where the bug is present?

ssborbis commented 1 year ago

Oh, I should say I'm using the code from the master branch. Lemme see if there's a difference between the latest code and the latest release...

ssborbis commented 1 year ago

I checked the latest release 1.46.14 and I can't get the bug there either. I'll try your config and see if anything stands out.

sojusnik commented 1 year ago

Oh, sorry, my bad! It works properly now, had to adjust some settings! Many thanks for this awesome extension!