search

ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
354 stars 37 forks source link

ContextSearch on other Extension-Pages #682

Open ThomasSeeker opened 9 months ago

ThomasSeeker commented 9 months ago

Hey there,

I finally have a new Computer and the hardware is now easily capable of opening ContextSearch-Menus lightening fast. ... So now I have actually no reason at all anymore, to use the native Firefox-Context-Menu and would like to disable it alltogether. ( ... with my old hardware it was a bit faster and therefore I used ContextSearch only as a secondary Context-Menu (with long clicks)).

But here comes one little problem: Is there a way to use ContextSearch on other extension-pages too? ... I use the Feedbro-Extension for my feeds and would love to get the links, text-selections, etc. from that page into my ContextSearch-Apps. ... is ContextSearch disabled there? ... is there a reason for this?

Best greetings, ;-)

ssborbis commented 9 months ago

But here comes one little problem: Is there a way to use ContextSearch on other extension-pages too?

I'm guessing that functionality is disabled due to security concerns. As far as I know, you cannot inject code into another addon's pages, so the only option left to this addon is the searching via the context menu. It would be nice if there were a way, but the webextensions API is somewhat limited, so I'm afraid you'll have to continue relying on the context menu as a fallback.

ThomasSeeker commented 9 months ago

Thank you for your fast answer, ssborbis!

Ok, I understand. That's a pitty. So I have to stay with the native context-menu on other extension-pages.

But since its suppression/disabling does not work on those pages anyway ... is there a way to disable or delay it at least on regular pages? ... Right now it pops up after 1 second. After 10 seconds or so it couldn't be triggered by accident anymore. (Right now this still happens, also because I use the right mouse button for gestures.)

ssborbis commented 9 months ago

But since its suppression/disabling does not work on those pages anyway ... is there a way to disable or delay it at least on regular pages? ... Right now it pops up after 1 second. After 10 seconds or so it couldn't be triggered by accident anymore. (Right now this still happens, also because I use the right mouse button for gestures.)

Just so we're on the same page, are you wanting to completely disable the quick menu? Also, if the menu is configured properly, you shouldn't see both the context menu and the quick menu at the same time, from the same right-click. It's a bit tricky because of how the mouse events work on different browsers, but there are some settings to hopefully prevent the double-menus on any system. Can you give a few more details about what exactly is happening, and what you want it to do differently?

ThomasSeeker commented 9 months ago

Thank you ssborbis, for looking into this!

I am talking about the "Quick Menu" aka "Popup Menu".

My settings are: Open it anywhere with a Right-Mouse-Click.

And on the settings page it says: "Hold right button ~1s and release for default context menu". ... and this is exactly what is happening! ... I never see both at the same time. All is working accordingly.

But what I would really like to have, would be the "1s" be increased to "5s".

The reason is: With my new hardware the Quick-Menu opens so quick :-) , that I made it my primary main Context Menu. And I actually don't really need the native one any longer. ... And now the hold-down-function of the right mouse-button gets freed for certain mouse gestures, which I would like to use. ...

And with them the native context-menu opening after 1s is annoying.

I already searched the web for firefox-addons or other ways to achieve this, but did not have any luck so far.

Could you help out with this, ssborbis?

ssborbis commented 9 months ago

But what I would really like to have, would be the "1s" be increased to "5s".

Ah. Yeah, I think there's a setting for that. Lemme check...

Looking at the code, I think the setting quickMenuHoldTimeout (CS Options -> Advanced) is doing double-duty for both the HOLD method and the CLICK method. Try changing that to a higher value. I'll test also, but my results may not match up with yours.

ThomasSeeker commented 9 months ago

Ok, I tried this here.

To describe more detailed: Here on my system 2 things can happen on the releasing of the right mouse button after a single click.

  1. If I hold the mouse button down for a short time and then release it, the Quick Menu opens.

  2. If I hold the mouse button down for a bit longer and then release it, the native menu opens. ... Even though I have set it to open with other methods (I tried several others).

Now if I increase the quickMenuHoldTimeout ... it only changes the time when the 1. behavior shifts to the 2.. ...

So there is no time-window opening, in which I could perform a hold-down-mouse-gesture without opening a menu.

Maybe the easiest solution would be to disable the native context menu completely on single-right-clicks and instead force it to only use the selected method dedicated to it, i.e. Shift, Alt, Ctrl, Double-Click, ... ?

Would this be possible?

ssborbis commented 7 months ago

Maybe the easiest solution would be to disable the native context menu completely on single-right-clicks and instead force it to only use the selected method dedicated to it, i.e. Shift, Alt, Ctrl, Double-Click, ... ?

I'm looking to see if there's a setting combination that will get you what you're looking for. Just for a sanity check, you want to be able to hold the right mouse button down for a certain length of time ( say 1 second ) and get no menus, (browser UI context menu or this addon's quick menu). Moving the default context menu to a double-click is already an option, but like you said, there doesn't seem to be a setting to then cancel opening the qm.

ThomasSeeker commented 7 months ago

Firstly: Thank you ssborbis for looking into this again! :-)

I too, looked into this again just now. And very unexpectedly I found a solution. That is: If I set ui.context_menus.after_mouseup to false in about:config ... the native/default context menu does not appear anymore at all after holding down the right button for any amount of time. It only appears after the designated double click (or similar). ... Now the hold-down-button is finally freed to be used in mouse-gestures. ... Wonderful!

Sorry for not having checked the ui.context_menus.after_mouseup in the first place and causing all that noise. :-/

ThomasSeeker commented 7 months ago

PS: Made a small donation. Thank you again for this wonderful Addon! ... I am using it constantly.

ssborbis commented 7 months ago

PS: Made a small donation. Thank you again for this wonderful Addon! ... I am using it constantly.

Thank you so much! ... for the donation and the consistent feedback and suggestions. This addon is only what it is because of users like you who are willing to take the time to report bugs and make feature requests. Cheers!