ssborbis / ContextSearch-web-ext

Search engine manager for modern browsers
315 stars 35 forks source link

Performance impact Speedometer 3.0 #686

Open fy0z9b7q opened 3 months ago

fy0z9b7q commented 3 months ago

This is a duplicate of issue #257 https://github.com/ssborbis/ContextSearch-web-ext/issues/257 but updated for Speedometer 3.0.

When "Enable searching via popup menu" is enabled in ContextSearch, the Firefox 123.0.1 scores for Speedometer 3.0 are cut in nearly half (18.4 +/- 0.59 to 9.99 +/- 0.26 on my machine).

Even if this is not a "real world" performance degradation, it is a "bad look". I have no idea whether this is a Firefox issue or a ContextSearch issue, but I hope someone can improve it.

fy0z9b7q commented 3 months ago

Additional data: I enabled the context search extension with the most users from addons.mozilla.org, Context Search. With it enabled (searching via popup menu) there was no measurable Speedometer 3.0 performance degradation.

ssborbis commented 3 months ago

I feel like this has been mentioned before. I'll have to look back through past threads, but I though it was an issue regarding how Speedometer runs it's tests (iframes maybe?) and how this addon injects into iframes. I seem to remember the test being misleading as a result, but I can look again.

ssborbis commented 2 months ago

The latest code in the master branch moves iframe injection to on-demand and when iframes receive focus. This has the effect of significantly improving Speedometer 3.0 results.