search

ssbucarlos / smash-ultimate-blender

Blender Plugin containing utilities for Smash Ultimate Models and Animations.
45 stars 9 forks source link

Swing Bone Export Bug #164

Closed JArmstrongArt closed 2 years ago

JArmstrongArt commented 2 years ago

Download Specimen of Files Another issue I was recommended to list, though I'm not entirely sure it was this tool's fault myself. I used this tool to export a new skeleton for my model in which all I did after importing this skeleton beforehand with this very same tool is added a few swing bones. I updated my swing.prc to match, and the swing bones work fine. However, now that I have updated my skeleton, the skeleton stops animating right when moving on the ground as shown in the image below. In the air, it looks fine, but on the ground, this happens. I did not alter the skeleton in any way other than these swing bones. image

ssbucarlos commented 2 years ago

The behavior seems to indicate an issue with the .nusktb, and since only swing bones were added then its most likely an issue with the recently re-written bone re-ordering code. This is a high priority issue imo so i will look into it asap. will let u know when its fixed

ssbucarlos commented 2 years ago

in the meantime u can also manually re-order bones in ssbh_editor, i recommend moving the new swing bones down the list until they are with the vanilla swing bones

JArmstrongArt commented 2 years ago

Was unaware I could manually order bones, I'll go do that now as a workaround, hopefully you can get it sorted so that this tool orders them properly from the get-go. You were already aware of this from conversations outside of this issue, but for transparency to others, I did have 'Order & Values' set when exporting my skeleton with this tool, so that's not the issue.

JArmstrongArt commented 2 years ago

UPDATE: Just out of curiosity, I rolled back my plugin install to commit 27505ff, before you added that recent merge with the helper bone stuff. However, despite a re-export with this rolled-back version, the problem persists after checking my bone order on both my old and new skeleton in SSBH Editor. I only tried this because I know you mentioned to me that a recent push might have caused this.

ssbucarlos commented 2 years ago

allright i am looking into it now.

ssbucarlos commented 2 years ago

i pushed a fix and i tested with a skel with added swing bones + helper bones + normal bones and tested in game. If u run into the issue again just comment here to let me know