search

ssbucarlos / smash-ultimate-blender

Blender Plugin containing utilities for Smash Ultimate Models and Animations.
45 stars 9 forks source link

(Exo Skel) When building the bone list, automatically set the Smash Bone if the helper's name without the prefix is in the og bones. #98

Closed Julian0555 closed 2 years ago

Julian0555 commented 2 years ago

Not a necessary addition but as someone who usually uses the same naming conventions as Ult for my exo bones this helps a lot!

ScanMountGoat commented 2 years ago

This would be a nice addition, but there may be some issues with applying this automatically. It would be great if this was an option the user could configure. The easiest may be to just add this as a button.

Julian0555 commented 2 years ago

Apologies for the branch weirdness/closing as well as the delay! The newly added "Update Bone Pairing List" gave me the idea to make the feature separate from list building, though I wouldn't mind changing it to work any which way. Unsure about my naming/description for it. In retrospect, I think you were alluding to doing it this way with your first response, though my brain initially led me in a different direction. Let me know what you think! image

ScanMountGoat commented 2 years ago

The UI looks great, and the descriptions are clear. Once the prefix removal is fixed, this will be good to merge.

The other issue is that the current implementation automatically pairs bones with no parent. This gives errors like "Cannot pair H_Exo_Trans to Trans. Trans has no parent." We can just require the user to fix this for now, so I wouldn't worry about trying to handle this automatically.

Julian0555 commented 2 years ago

I am weirdly consistent with these time gaps lol. How does this look? The prefix issue should be fixed, and I added a check for the smash bone parent.

ScanMountGoat commented 2 years ago

Looks good.