Enhancement: Graph Performance

On larger graphs it may time out or crash. Perhaps limit the output of getNeighbors.perl?

Here are the steps: https://worldofcode.org/lookupresult?sha1=8e4a707f68f0ed47de3fd01682679af05c74389c&type=commit Create graph click on red dot Server shows project: ;0mp_freebsd;

Running it on the server it produces 36690 byte output:

~/lookup/getNeighbors p 1 0mp_freebsd | wc Use of uninitialized value $v in division (/) at /home/audris/lookup/getNeighbors.perl line 169. Use of uninitialized value $v in division (/) at /home/audris/lookup/getNeighbors.perl line 169. Use of uninitialized value $v in division (/) at /home/audris/lookup/getNeighbors.perl line 169. 447 528 36690

Debugger on ffox shows:

TypeError: Invalid attempt to destructure non-iterable instance. In order to be iterable, non-array objects must have a [Symbol.iterator]() method. _nonIterableRest FastGraph.js:12 _slicedToArray FastGraph.js:10 getData FastGraph.js:69 initGraph FastGraph.js:95 makeGraph FastGraph.js:31 promise callbackmakeGraph FastGraph.js:30 onClick FastGraph.js:154 contextListener on.js:27 onAdd on.js:70 default each.js:5 default on.js:94 initGraph FastGraph.js:132 makeGraph FastGraph.js:31 promise callbackmakeGraph FastGraph.js:30 componentDidMount FastGraph.js:36 React 6 unstable_runWithPriority scheduler.development.js:653 React 5 unstable_runWithPriority scheduler.development.js:653 React 6

Audris

On 12/10/20 10:44 AM, Lomax, Dylan wrote:

Do you have the commit that caused it?

-Dylan

On Thu, Dec 10, 2020, 09:59 Audris Mockus <audrism@gmail.com mailto:audrism@gmail.com> wrote:

Dylan, regarding 5) yes it would make sense to add the button.

James and Dylan:
Here is more info: it seems that response to clicks works except sometimes there appear to be some errors that lead to
stalling behavior:

e.g.,
CommitMap 2 CommitMap.js:185:9
TypeError: Invalid attempt to destructure non-iterable instance.
In order to be iterable, non-array objects must have a [Symbol.iterator]() method.
      _nonIterableRest FastGraph.js:12
      _slicedToArray FastGraph.js:10
      getData FastGraph.js:69
      initGraph FastGraph.js:95
      makeGraph FastGraph.js:31
      promise callback*makeGraph FastGraph.js:30
      onClick FastGraph.js:154
      contextListener on.js:27
      onAdd on.js:70
      default each.js:5
      default on.js:94
      initGraph FastGraph.js:132
      makeGraph FastGraph.js:31
      promise callback*makeGraph FastGraph.js:30
      onClick FastGraph.js:154
      contextListener on.js:27
      onAdd on.js:70
      default each.js:5
      default on.js:94
      initGraph FastGraph.js:132
      makeGraph FastGraph.js:31
      promise callback*makeGraph FastGraph.js:30
      componentDidMount FastGraph.js:36
      React 6
      unstable_runWithPriority scheduler.development.js:653
      React 5
      unstable_runWithPriority scheduler.development.js:653
      React 5
FastGraph.js:97:11

On 12/9/20 7:25 PM, Audris Mockus wrote:
 > Clarification,
 >
 > 1) click-through works on the console a request is made, but I am not sure the graph changes
 > 2) click works for green (file); author blue; yellow? - commit, black - project; but not red?
 >
 > What I mean works is there is a log on the server side, but the view appears to stay unchanged.
 >
 >
 >   Audris
 >
 >
 > On 12/9/20 4:29 PM, Lomax, Dylan wrote:
 >> 1-4 seems more addressed to James, but could you explain what you mean for point 5? I'm guessing that you mean
that we
 >> could build maps with tree and blob shas as well? I made the graph button a separate component so it would be
pretty
 >> easy to add them to those as well if that's the case.
 >>
 >> -Dylan
 >>
 >> On Wed, Dec 9, 2020, 15:47 Audris Mockus <audrism@gmail.com <mailto:audrism@gmail.com> <mailto:audrism@gmail.com
<mailto:audrism@gmail.com>>> wrote:
 >>
 >>     [External Email]
 >>
 >> https://worldofcode.org/lookupresult?sha1=587f18c43805b9fd26d570b66a027f5c45e9dfd1&type=commit
 >>
 >>
 >>     Clarification:
 >>     1) what colors mean (what type of nodes) green, black red, yellow, and blue
 >>     2) is it easy to add labels?
 >>     3) is it easy to change depth? (the server side has the parameter, so it is a client-side question)
 >>     4) What about the click-through
 >>     5) the latest version of the server side handles not just commits, so buttons/click-through could be done
for them
 >>     as well.
 >>
 >>
 >>     Many thanks, Audris
 >>

ssc-oscar / DRE

Enhancement: Graph Performance #46