fix: bump version to 1.1.3

ssc-oscar / oscar.py

Python interface for OSCAR data

GNU General Public License v3.0

4 stars 10 forks source link

fix: bump version to 1.1.3 #8

Closed audrism closed 5 years ago

user2589 commented 5 years ago

There is no need to bump version - it will be done automatically.

only fix commits: minor revision (bump the last number)
new features: major revision (bump the second number)
breaking changes: new version (the first number)

audrism commented 5 years ago

Just did it to verify that the pypi did not appear to get the latest data: https://pypi.org/project/oscar/ shows 1.1.0
since a bunch of new relations were added, perhaps it should be 1.2.0 now?

user2589 commented 5 years ago

It did not pass tests (red cross in front of the commit) so it did not publish a new version. The same happened last time, too. I'm going to check Travis log to see what happened

audrism commented 5 years ago

@dkennard3 @atutko2 does the current version build on our servers? If not, can it be made to pass all the tests? Once it it passes the tests the version number should be bumped up to 1.2.0 since there are many new relations added. Also: new feature pull request needs to be submitted outlining the changes (travis builds/deploys to pypi after such PR is merged)

user2589 commented 5 years ago

The problem is with the release script. I'll fix it. To indicate a new feature, commit message should be prepended with a "feat:". Breaking changes prefix is "BREAKING CHANGE:". Full reference can be found here: https://www.conventionalcommits.org/

audrism commented 5 years ago

Thank you!