ssc-spc-ccoe-cei / azure-guardrails-solution-accelerator

This implementation automates reporting to verify compliance with GC Cloud Guardrails. SSC and TBS review the results. Cette mise en œuvre automatise la production de rapports afin de vérifier la conformité aux mesures de sécurité infonuagique du GC. SPC et SCT examinent les résultats.
Other
11 stars 5 forks source link

[BugFix] - GR1 | Validation 4 | Comment Mismatch for Missing Lock #232

Closed singhgss closed 1 month ago

singhgss commented 1 month ago

Overview/Summary

This Pull Request fixes the unclear comment related to non-compliant Log Analytics Workspace (LAW) in the "User Account GC Event Logging Check (M)" guardrail. The issue pertains to a confusing comment when a department's LAW is missing a read-only lock, providing inaccurate messaging for the end user.

This PR fixes/adds/changes/removes

Fixes #230

  1. Fixes unclear comments: Updates the English and French comments for the scenario where the department's LAW is missing a read-only lock.
  2. Ensures correct compliance check: Verifies that the correct non-compliance message is provided when the LAW is missing the required read-only lock.

Breaking Changes

  1. None: This PR introduces no breaking changes as it only updates comments and clarifies expected behavior.
  2. N/A

Testing Evidence

Screenshots: N/A

As part of this Pull Request I have