GR1 V3 Bugfix for GA Count for maximum 5 and MFA validation - Githubissues

ssc-spc-ccoe-cei / azure-guardrails-solution-accelerator

This implementation automates reporting to verify compliance with GC Cloud Guardrails. SSC and TBS review the results. Cette mise en œuvre automatise la production de rapports afin de vérifier la conformité aux mesures de sécurité infonuagique du GC. SPC et SCT examinent les résultats.

Other

11 stars 5 forks source link

GR1 V3 Bugfix for GA Count for maximum 5 and MFA validation #233

Closed dutt0 closed 1 month ago

dutt0 commented 1 month ago

Overview/Summary

This pull request fixes the total global administrator count for validation 3 of Guardrail 1. It also fixes a bug for a test case when number of user accounts with bad MFA is not null

This PR fixes/adds/changes/removes

Fixes the compliance status and message for the test case where number of users with MFA is null or the count is 0
Updates logic to look for a minimum of 2 and maximum of Global Administrators and fail otherwise.
Also updates the comment as in #228

Breaking Changes

N/A

Testing Evidence

Tested in the tenant

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[ ] Updated relevant and associated documentation.
[x] Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)