ssc-spc-ccoe-cei / azure-guardrails-solution-accelerator

This implementation automates reporting to verify compliance with GC Cloud Guardrails. SSC and TBS review the results. Cette mise en œuvre automatise la production de rapports afin de vérifier la conformité aux mesures de sécurité infonuagique du GC. SPC et SCT examinent les résultats.
Other
7 stars 4 forks source link

GR 1 & 3: GA MFA Check Does Not Appear in Workbook #74

Closed MathesonSho closed 8 months ago

MathesonSho commented 8 months ago

Describe the bug (s)

  1. When clients deploy the solution for the first time they have not uploaded any of the attestations. In this case, the Check-GAAuthenticationMethods will fail and not return any results to the workbook.

  2. When clients upload the attestation with the wrong format. In this case, the module fails and it does not return any results to the workbook.

To Reproduce A) Steps to reproduce the behavior:

  1. Go to the storage account and remove the upn.txt file
  2. Rerun main and backend runbooks
  3. Review main logs for error
  4. See error/ no resulting control for the GA MFA Check in the workbook.

B) Steps to reproduce the behavior:

  1. Go to the storage account and upload the upn.txt file (2 in the correct format and 3 in the wrong i.e., without the hyphen)
  2. Rerun main and backend runbooks
  3. Review main logs for error
  4. See error/ no resulting control for the GA MFA Check in the workbook.

Expected behavior In the event that there is an error; the control should show as non-compliant and the module still runs. This would control would show up in the workbook as non-compliant.

Screenshots image image

image

image

image

dutt0 commented 8 months ago

For this specific scenario (no GlobalAdministratorsUPN.txt in the storage account), the error in the error log is because of the Write-Error comment that was put in place for the developers to see the log. The workbook will still work as intended. However, since it may be creating a confusion, we will remove the print output.