Closed dutt0 closed 9 months ago
@alalvi00 As you mentioned yesterday, you have #microsoft.graph.passwordAuthenticationMethod and #microsoft.graph.AuthenticatorAuthenticationMethod and both are enabled for MFA. This logic goes by that perspective.
@alalvi00 As you mentioned yesterday, you have #microsoft.graph.passwordAuthenticationMethod and #microsoft.graph.AuthenticatorAuthenticationMethod and both are enabled for MFA. This logic goes by that perspective.
Thats fine but a user will also pass if they only have password and email and I have tested this in the test tenant
Just for the reference in localexecution this is what I see for $comments and the ComplianceStatus is also false. Thanks for your testing and giving reviews. I will discuss the logic in tomorrow's meeting and thereafter finalize the PR
Testcase 1 : -<testuser's upn>@xxxxxxxxx.onmicrosoft.com -< ila's upn>@xxxxxxxxx.onmicrosoft.com
Testcase 2 : -<testuser's upn>@xxxxxxxxx.onmicrosoft.com -<Ali's upn>@xxxxxxxxx.onmicrosoft.com
Thanks for your reviews @alalvi00 @singhgss. I am refactoring this function. Cancelling this PR. I will raise another PR later
Overview/Summary
This pull request fixes the reporting bug in 163gccspm for GR1 & Gr3 GA MFA UPN list feature.
This PR fixes/adds/changes/removes
In total, there should be 4 types of authentication methods to consider:
microsoft.graph.microsoftAuthenticatorAuthenticationMethod
microsoft.graph.phoneAuthenticationMethod
microsoft.graph.passwordAuthenticationMethod
microsoft.graph.emailAuthenticationMethod
This PR has the fix for the MFA authentication by including two more authentication methods that users may have. Since dev tenant users did not have password and email authentication methods, this issue was not prominent in that tenant. However, the users in Test tenant carries these MFA. This pull request has the fix for this use case.
Testing Evidence
As part of this Pull Request I have
main
branch