search

ssc-spc-ccoe-cei / gcp-tools

This repo is meant to be a submodule of the gcp-repo-template repository. https://github.com/ssc-spc-ccoe-cei/gcp-repo-template
3 stars 3 forks source link

fix: renaming root sync in configure-kcc-access.sh #75

Closed lucstjean-ssc closed 5 months ago

lucstjean-ssc commented 6 months ago

In anticipation of the new group and gcp resource naming convention, we are renaming the root-sync.yaml file and its content to support the new naming standard.

root-sync.yaml

cat << EOF > ./root-sync.yaml
apiVersion: configsync.gke.io/v1beta1
kind: RootSync
metadata:
  name: "${CONFIG_SYNC_NAME}"
  namespace: config-management-system
spec:
  sourceFormat: unstructured
  git:
    repo: "${CONFIG_SYNC_REPO}"
    branch: main # eg. : main
    dir: "${CONFIG_SYNC_DIR}" # eg.: csync/deploy/<env>
    revision: "${CONFIG_SYNC_VERSION}"
    auth: token
    secretRef:
      name: git-creds
EOF

https://github.com/ssc-spc-ccoe-cei/gcp-tools/blob/afc4ca65febda9852881180def11b922e4ea5b18/scripts/bootstrap/configure-kcc-access.sh#L46

lucstjean-ssc commented 6 months ago

/lgtm We would need any referenced modified - the readme https://github.com/ssc-spc-ccoe-cei/gcp-tools/tree/main/scripts/bootstrap#iam-and-access-configuration

Readme updated; good catch!

borkodjurkovic-ssc commented 6 months ago

lgtm. Just a note that there are some other referenced to root-sync.yaml (e.g. in couple of README files in pubsec-declarative-toolkit repo).