search

sscargal / pmemchk

MIT License
0 stars 1 forks source link

[optane/check_dimm_population] "$err_state" should be "$ERR_STATE" #158

Closed sscargal closed 2 years ago

sscargal commented 2 years ago

In optane/check_dimm_population, the script sets err_state=true|false but the final check is requires an uppercase ERR_STATE

# grep -n err_state *
check_dimm_population:34:    err_state=true
check_dimm_population:42:    err_state=true
  # Return the final PASS/FAIL to the user
  if [ "${ERR_STATE}" = true ] ; then
    rule_result FAILED "Detected an invalid PMem population. Counted ${NUM_OF_DIMMIDS} PMem modules. See previous errors."
  else
    rule_result PASSED "Detected ${NUM_OF_DIMMIDS} PMem modules. Population looks good."
  fi