search

sscarpa / google-api-php-client

Automatically exported from code.google.com/p/google-api-php-client
Apache License 2.0
0 stars 0 forks source link

Google_ServiceException instantiation triggers a fatal error on php < 5.3.0 #182

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Create an instance of Google_ServiceException on PHP < 5.3.0

What is the expected output? What do you see instead?

a fatal error is triggered

What version of the product are you using? On what operating system?

PHP 5.2.6

Please provide any additional information below.

The fatal error is caused by the missing "previous" argument in the Exception 
constructor in PHP before version 5.3.0.
Please find attached a patch that solves the problem; with this patch the 
library works ok on PHP 5.2.6

Original issue reported on code.google.com by lorenzo....@cubica.eu on 29 Aug 2012 at 2:50

Attachments:

GoogleCodeExporter commented 8 years ago 
Thank you for reporting this issue, and for the patch.

Before we can accept the patch, you will need to fill out either the individual 
or corporate Contributor License Agreement.

If you are an individual writing original source code and you're sure you own 
the intellectual property, then you'll need to sign an individual CLA.
   - http://code.google.com/legal/individual-cla-v1.0.html
If you work for a company that wants to allow you to contribute your work to 
this client library, then you'll need to sign a corporate CLA.
   - http://code.google.com/legal/corporate-cla-v1.0.html

Follow either of the two links above to access the appropriate CLA and 
instructions for how to sign and return it. Once we receive it, we'll add you 
to the official list of contributors and be able to accept your patches.

Original comment by chirags@google.com on 29 Aug 2012 at 8:42

GoogleCodeExporter commented 8 years ago 
I've sent the signed CLA to cla-submissions@google.com, thanks

Original comment by lorenzo....@cubica.eu on 30 Aug 2012 at 8:40

GoogleCodeExporter commented 8 years ago 
Thank you. This patch was submitted in r493, and is now available on trunk.

Original comment by chirags@google.com on 11 Sep 2012 at 8:16