sschmidTU / mr-kanji-search-wtk

WTK-Search is a Kanji search engine using (multiple) Wanikani radicals or RTK names, on a RTK element dataset of 3000+ Kanji
https://sschmidtu.github.io/mr-kanji-search-wtk/
7 stars 2 forks source link

Some WK kanji not searchable by name because they have replacements #17

Closed sschmidTU closed 3 years ago

sschmidTU commented 3 years ago

For example i just fixed 案 not being searchable by its WK name/meaning plan, which was being replaced with undertake (not the best example, as i then removed the whole replacement which was unnecessary).

-> check for all WK kanji names if they have a replacement, and add their WK name/meaning to the replacements as an option (create WK open framework script to get all the names, then check them programmatically whether they exist in replacements as keys)

sschmidTU commented 3 years ago

With the last commit all WK Kanji should actually be searchable by name now :D Improved the find_unfindable_WK_Kanji()̀ inWTKUtil`, simpler and should find all cases now.

These were the final kanji that weren't findable before the above commit, but the find_unfindable function didn't catch them:

couldn't find 久 by long time
couldn't find 第 by ordinal number prefix
couldn't find 湯 by hot water
couldn't find 々 by repeater
couldn't find 館 by public building
couldn't find 枚 by flat objects counter
couldn't find 産 by give birth
couldn't find 済 by come to an end
couldn't find 筆 by writing brush
couldn't find 奏 by play music
couldn't find 還 by send back
couldn't find 匹 by small animal
couldn't find 笠 by conical hat
couldn't find 盆 by lantern festival
couldn't find 穂 by head of plant
couldn't find 扉 by front door
couldn't find 栃 by horse chestnut
couldn't find 憧 by long for
couldn't find 諦 by give up

also the repeater 々 was not findable because it was not in the kanji data, probably because it's not considered a kanji by RTK, Jisho.org etc., but it is by Wanikani. Added as kanji now.