search

sschueller / peertube-android

Thorium, a PeerTube Android Client
https://github.com/Chocobozzz/PeerTube
GNU Affero General Public License v3.0
341 stars 53 forks source link

Playback speed and quality indicator bugs #207

Open sschueller opened 4 years ago

sschueller commented 4 years ago

There appear to be a few bugs:

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/92055672-playback-speed-and-quality-indicator-bugs?utm_campaign=plugin&utm_content=tracker%2F89466969&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F89466969&utm_medium=issues&utm_source=github).
Poslovitch commented 4 years ago
  • Change in video speed the current selection is no updated until the fragment is completely closed.
  • Change in video quality the current selection is no updated until the fragment is completely closed.

I have noticed these two but could not find a fix for them. This likely has to do with how Fragments work: the "text" is generated in the onCreateView() which is seemingly not called after the overlaying fragment is closed. I don't know if there's a method in Android that'd be called when a view comes back at the "top layer" of the screen. I haven't read docs about that yet.

  • Change in video speed does not update the checkmark until the fragment is completely closed.

As far as I am aware, this bug occurred prior to the merge of #204. Like the previous two bugs, I could not find a fix as I'm not used to how fragments work on Android. This will require me to read some docs or that someone else can come with a fix.

sschueller commented 4 years ago

ok, I will take a look. thanks