sschueller / peertube-android

Thorium, a PeerTube Android Client
https://github.com/Chocobozzz/PeerTube
GNU Affero General Public License v3.0
341 stars 53 forks source link

Some video cannot be played #233

Closed freeboub closed 1 year ago

freeboub commented 3 years ago

Some video cannot be played (even make the application crash)

You can find a sample on thinker instance, on thinkerview video: https://thinkerview.video/videos/watch/00eb921c-0a8f-4bf2-8f94-a5a93bc4ae8b

I already avoid the crash in : https://github.com/sschueller/peertube-android/pull/231

The explanation of this crash is explained here: https://framacolibri.org/t/video-json-missing-files-field/8908

ie sometimes files is empty and should be retrieved from streamingPlaylists.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/93393695-some-video-cannot-be-played?utm_campaign=plugin&utm_content=tracker%2F89466969&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F89466969&utm_medium=issues&utm_source=github).
freeboub commented 3 years ago

I have already implemented a local patch: parse streamingPlaylists and use it is files is empty. I can read the video, but exoplayer doesn't display playback time correctly ... (It stays always 5 seconds, where position is increasing) I also try to upgrade exoplayer to 2.12.0, now position and duration are increasing ... Notice that I have no idea on how to handle this when R.string.pref_torrent_player_key is enabled ...

sschueller commented 3 years ago

Related https://github.com/sschueller/peertube-android/issues/181 ?

freeboub commented 3 years ago

I don't think so, in that case there is no video url at all. The url cannot be parsed from server!

dhk2 commented 3 years ago

yeah, this seems to be a symptom of the problem I was running into with sites that no longer support legacy webtorrents, thus there is no way to make it work with the torrent player because it indicates that the site doesn't have torrent compatible files