search

sscotth / file-icon-supplement

Additional file extension icons for all themes including full color (soon) icons.
MIT License
5 stars 2 forks source link

Uncaught TypeError: Cannot read property 'dispose' of undefined #13

Closed SympleKaos closed 9 years ago

SympleKaos commented 9 years ago

[Enter steps to reproduce below:]

1.I get this error when my editor opens.

Atom Version: 0.194.0 System: Microsoft Windows 8.1 Thrown From: file-icon-supplement package, v0.7.9

Stack Trace

Uncaught TypeError: Cannot read property 'dispose' of undefined

At C:\Users\Josh\.atom\packages\file-icon-supplement\lib\file-icon-supplement-view.coffee:154

TypeError: Cannot read property 'dispose' of undefined
    at FileIconSupplementView.module.exports.FileIconSupplementView.removeFindAndReplaceEvent (C:\Users\Josh\.atom\packages\file-icon-supplement\lib\file-icon-supplement-view.coffee:339:42)
    at FileIconSupplementView.module.exports.FileIconSupplementView.loadFindAndReplaceSettings (C:\Users\Josh\.atom\packages\file-icon-supplement\lib\file-icon-supplement-view.coffee:317:21)
    at FileIconSupplementView.module.exports.FileIconSupplementView.loadAllSettings (C:\Users\Josh\.atom\packages\file-icon-supplement\lib\file-icon-supplement-view.coffee:384:12)
    at C:\Users\Josh\.atom\packages\file-icon-supplement\lib\file-icon-supplement-view.coffee:32:17
    at process._tickCallback (node.js:357:13)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "Search",
      "view-tail-large-files",
      "scroll-sync"
    ],
    "themes": [
      "atom-dark-ui",
      "seti-syntax"
    ],
    "followSymlinks": true
  },
  "file-icon-supplement": {
    "tabIcons": false,
    "treeViewIcons": false,
    "fuzzyFinderIcons": false,
    "findAndReplaceIcons": false,
    "grammarStatusIcons": false,
    "grammarSelectorIcons": false
  }
}

Installed Packages

# User
atom-alignment, v0.12.0
atom-color-highlight, v3.0.9
autocomplete-plus, v2.12.0
autocomplete-snippets, v1.2.0
color-picker, v1.7.0
column-select, v0.2.0
compare-files, v0.4.1
file-icon-supplement, v0.7.9
file-icons, v1.5.4
linter, v0.12.1
minimap, v4.7.6
seti-syntax, v0.3.3

# Dev
No dev packages
sscotth commented 9 years ago

Thanks for reporting. Should be fixed in https://github.com/sscotth/file-icon-supplement/commit/503243c59167bce29baf60dc7b0c73a59b2cf2bf and v0.7.10

SympleKaos commented 9 years ago

Just had a chance to update. After restarting Atom I didn't get the crash. Just wanted to let you know that it appears fixed. Thanks!