sscpac / statick

Making code quality easier.
https://sscpac.github.io/statick/
Creative Commons Zero v1.0 Universal
72 stars 14 forks source link

Remove bionic fix mypy #453

Closed gregtkogut closed 1 year ago

gregtkogut commented 1 year ago

I could use some help completing this PR.

The remaining problem is that tox testing hangs indefinitely in 20.04 (all Python versions). It hangs while running test_groovylint_tool_plugin.py. I tried to debug by running tox on a 20.04 docker container, and I could not replicate the problem.

A summary of what this PR does:

  1. Adds 22.04 testing back into CI. Several important stages were inadvertantly being skipped by some typos.
  2. Fixes some statick analysis findings.
  3. Removes bionic from CI.
codecov[bot] commented 1 year ago

Codecov Report

Merging #453 (bab6d5b) into main (6d2b1a6) will decrease coverage by 2.93%. The diff coverage is 88.88%.

:exclamation: Current head bab6d5b differs from pull request most recent head 00d61ce. Consider uploading reports for the commit 00d61ce to get more accurate results

@@             Coverage Diff             @@
##              main     #453      +/-   ##
===========================================
- Coverage   100.00%   97.06%   -2.94%     
===========================================
  Files           58       58              
  Lines         3332     3338       +6     
===========================================
- Hits          3332     3240      -92     
- Misses           0       98      +98     
Impacted Files Coverage Δ
statick_tool/reporting_plugin.py 97.14% <0.00%> (-2.86%) :arrow_down:
statick_tool/tool_plugin.py 100.00% <100.00%> (ø)
...tatick_tool/plugins/tool/shellcheck_tool_plugin.py 56.66% <0.00%> (-43.34%) :arrow_down:
...tatick_tool/plugins/tool/uncrustify_tool_plugin.py 75.36% <0.00%> (-24.64%) :arrow_down:
statick_tool/plugins/tool/cppcheck_tool_plugin.py 85.10% <0.00%> (-14.90%) :arrow_down:
...tatick_tool/plugins/tool/clang_tidy_tool_plugin.py 90.14% <0.00%> (-9.86%) :arrow_down:
statick_tool/plugins/tool/cccc_tool_plugin.py 91.20% <0.00%> (-8.80%) :arrow_down:
...tatick_tool/plugins/tool/groovylint_tool_plugin.py 92.75% <0.00%> (-7.25%) :arrow_down:
...tatick_tool/plugins/tool/perlcritic_tool_plugin.py 95.55% <0.00%> (-4.45%) :arrow_down:
statick_tool/statick.py 97.90% <0.00%> (-2.10%) :arrow_down:
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gregtkogut commented 1 year ago

Codecov Report

Merging #453 (9b85cf1) into main (6d2b1a6) will decrease coverage by 2.67%. The diff coverage is 75.00%.

@@             Coverage Diff             @@
##              main     #453      +/-   ##
===========================================
- Coverage   100.00%   97.32%   -2.68%     
===========================================
  Files           58       58              
  Lines         3332     3333       +1     
===========================================
- Hits          3332     3244      -88     
- Misses           0       89      +89     

Impacted Files Coverage Δ
statick_tool/reporting_plugin.py 97.14% <0.00%> (-2.86%) ⬇️ statick_tool/tool_plugin.py 100.00% <100.00%> (ø) ...tatick_tool/plugins/tool/shellcheck_tool_plugin.py 56.66% <0.00%> (-43.34%) ⬇️ ...tatick_tool/plugins/tool/uncrustify_tool_plugin.py 75.36% <0.00%> (-24.64%) ⬇️ statick_tool/plugins/tool/cppcheck_tool_plugin.py 85.10% <0.00%> (-14.90%) ⬇️ ...tatick_tool/plugins/tool/clang_tidy_tool_plugin.py 90.14% <0.00%> (-9.86%) ⬇️ statick_tool/plugins/tool/cccc_tool_plugin.py 91.20% <0.00%> (-8.80%) ⬇️ ...tatick_tool/plugins/tool/groovylint_tool_plugin.py 92.75% <0.00%> (-7.25%) ⬇️ ...tatick_tool/plugins/tool/perlcritic_tool_plugin.py 95.55% <0.00%> (-4.45%) ⬇️ ...tick_tool/plugins/tool/clang_format_tool_plugin.py 99.18% <0.00%> (-0.82%) ⬇️ 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more