sscpac / statick

Making code quality easier.
https://sscpac.github.io/statick/
Creative Commons Zero v1.0 Universal
74 stars 14 forks source link

Add support for multi-line yaml syntax. #481

Closed tdenewiler closed 1 year ago

tdenewiler commented 1 year ago
tdenewiler commented 1 year ago

I tested the configuration file changes against a ROS package, node_example. Assuming you have that in a ROS1 workspace, and you have sourced the devel space, then do this.

python3 -m venv venv
. venv/bin/activate
cd <statick/dev/branch>
pip install .
cd <node_example_ws_root>
statick src/node_example/ --output-directory /tmp/x --log info --timings --level <level>

I tried all the levels in the default config.yaml file that is installed with Statick: sei_cert, threshold, objective_minus_pylint, objective, objective_with_format_minus_pylint, rosm_threshold, rosm_objective, self_check, ultimate, ruff.

All of the commands completed successfully. I noticed that the cmake discovery plugin discovered make targets each time, and the make tool successfully ran, usually taking the longest of all tool plugins to complete.

codecov[bot] commented 1 year ago

Codecov Report

Merging #481 (f538837) into main (ef2539a) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #481   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines         3375      3378    +3     
=========================================
+ Hits          3375      3378    +3     
Impacted Files Coverage Δ
statick_tool/config.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more