search

sscpac / statick

Making code quality easier.
https://sscpac.github.io/statick/
Creative Commons Zero v1.0 Universal
74 stars 14 forks source link

Fix for Dockerfile smell DL4000 #482

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "templates/Dockerfile" contains the best practice violation DL4000 detected by the hadolint tool.

The smell DL4000 occurs when the deprecated MAINTAINER instruction is used. In this pull request, we propose a fix for that smell generated by our fixing tool. We verified that the patch is correct before opening the pull request. To fix this smell, specifically, the MAINTAINER instruction is replaced by an equivalent LABEL instruction as recommended by the official guidelines.

This change is only aimed at fixing that specific smell. In the case the fix is not valid or useful, please briefly indicate the reason along with suggestions for possible improvements.

Thanks in advance.

codecov[bot] commented 1 year ago

Codecov Report

Merging #482 (ba8744f) into main (1e01e99) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines         3378      3378           
=========================================
  Hits          3378      3378

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

denewiler commented 1 year ago

483 fixed some underlying issues in our CI. Can you please merge our main branch into your fix branch? Thank you.