search

sscpac / statick

Making code quality easier.
https://sscpac.github.io/statick/
Creative Commons Zero v1.0 Universal
73 stars 14 forks source link

Drop support for Python 3.7 due to end-of-life on 27 June 2023. #487

Closed tdenewiler closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #487 (0c6687a) into main (303b504) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines         3378      3378           
=========================================
  Hits          3378      3378

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

xydesa commented 1 year ago

Does it matter if we do this separately from the plugin repos?

tdenewiler commented 1 year ago

I'm not certain if removing a classifier for a specific distribution in setup.py has any effect on PyPI or pip install. My best guess is that the classifier is only used for documentation purposes and will not have any effect. Users on Python 3.7 systems will still be able to pip install statick and the statick plugins and use them. It is not until we make changes to the Statick code that are not supported by Python 3.7 that users will see any issues.

One piece of evidence to back that up is the wheel found on PyPI at https://pypi.org/project/statick/#files. The built distribution is statick-0.9.4-py3-none-any.whl. To me that implies Statick will be installed on all versions of Python 3 and on any architecture (working is a separate matter).