Please upstream - Githubissues

ssddq / fw-ectool

12 stars 1 forks source link

Please upstream #1

Open magnetophon opened 1 year ago

magnetophon commented 1 year ago

Thanks for this handy little package! Any reason you didn't PR it to nixpkgs? If you want, I can also do it.

ssddq commented 1 year ago

I'm a little hesitant about submitting this to nixpkgs myself for two reasons:

The FrameworkComputer/EmbeddedController project carries warnings that this can cause hardware damage to your device, which makes me a little nervous about putting it in nixpkgs.
I only use ectool fanduty _ and ectool autfanctrl on the 11th generation model, and I didn't want to submit a pull request for something I haven't properly tested and can't commit to maintaining.

However, if you're willing to maintain it and think it should be on nixpkgs, please feel free!

magnetophon commented 1 year ago

Those reasons make sense, thanks.

Maybe there could be a warning when you install it, similar to when you try to install a pkg that is marked broken.
I have also only tested those commands plus the ones related to leds. On the other hand, I don't think it's reasonable to expect a maintainer to test every, or even most features of the software he packages. Not sure where the line should be drawn.

I'd be happy to maintain it, but I'd like to hear some other peoples opinions on this. I'll link this issue in a related discussion on nixos-hardware.

edmundmiller commented 9 months ago

I kinda agree, it doesn't need to be in nixpkgs, some examples of the Flake being used in a config should be enough. Kinda the beauty of Nix.

Probably going have less angry people with a borked laptop.