ssec-jhu / dplutils

Distributed(Data, Discovery) Pipeline Uitilities
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Fix test coverage in some areas missed due to ray #23

Closed amitschang closed 10 months ago

amitschang commented 10 months ago

There are more of these in the ray observers, focusing on pipeline here. While most of these lines are in fact executed, coverage can't tell due execution in ray workers, the fix is to explicity call these in test interpreter, which is useful anyhow.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f138f81) 86.42% compared to head (c899a1f) 91.85%.

:exclamation: Current head c899a1f differs from pull request most recent head a99d846. Consider uploading reports for the commit a99d846 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 86.42% 91.85% +5.42% ========================================== Files 7 7 Lines 221 221 ========================================== + Hits 191 203 +12 + Misses 30 18 -12 ``` | [Flag](https://app.codecov.io/gh/ssec-jhu/dplutils/pull/23/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssec-jhu/dplutils/pull/23/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | `91.85% <ø> (+5.42%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.