search

ssec-jhu / dplutils

Distributed(Data, Discovery) Pipeline Uitilities
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Fix test for ray observer in executor #33

Closed amitschang closed 9 months ago

amitschang commented 9 months ago

Meant to fix https://github.com/ssec-jhu/dplutils/issues/27. Ray doesn't seem to provide an API to wait for all pending tasks on an actor, so we give some time and triggers to flush out the system.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (63df416) 100.00% compared to head (e41c5be) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 265 269 +4 ========================================= + Hits 265 269 +4 ``` | [Flag](https://app.codecov.io/gh/ssec-jhu/dplutils/pull/33/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssec-jhu/dplutils/pull/33/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amitschang commented 9 months ago

@xiangchenjhu , I will update the comment, but these are just what I deemed reasonable values to balance catching real issues and giving enough chances to flush the data. Hasn't seemed to be a real issue with linux, for whatever reason mac may be faster/slower such that it pops up as an issue. If this causes issues later, we can attempt to be more deterministic by shutting ray down and passing files, but that seems overly complex for the present case.

xiangchenjhu commented 9 months ago

@amitschang Got it, thanks for the insight. It's intriguing to observe the differing performance between Linux and Mac in this scenario.