ssec-jhu / dplutils

Distributed(Data) Pipeline Uitilities
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Fix bug in task validation to handle variadic args #98

Closed amitschang closed 1 month ago

amitschang commented 1 month ago

This also handles the case of multiple positional only args - since we only support a single one which is the input dataframe - and where a keyword argument overlaps with this first argument.

resolves https://github.com/ssec-jhu/dplutils/issues/97

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (eed9a2e) to head (0fc81c8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #98 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 587 595 +8 ========================================= + Hits 587 595 +8 ``` | [Flag](https://app.codecov.io/gh/ssec-jhu/dplutils/pull/98/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssec-jhu/dplutils/pull/98/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu) | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssec-jhu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.