Closed amitschang closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
:loudspeaker: Thoughts on this report? Let us know!
@amitschang Sorry I didn't notice this yesterday as we weren't individually requested for a review. On it now...
sorry, I clicked 'update branch' thinking this was my PR from yesterday. Didn't mean to pollute the git history @amitschang @jamienoss
@amitschang Let us know when this is ready for another review.
My only remaining comment would be for us to better emphasize the fact that multiple sequential sets & gets are not possible within a single call to
control
. I.e., my previous review comments.
Cool, I think discussion of that fits well in the to-be-completed concepts
document that this one links to in a number of places, so I'll handle it there.
This adds some docs for development of a new controller, along with some reference stubs for material linked from there.
PR build of docs online: https://evolver-ng--159.org.readthedocs.build/en/159/development/controllers.html