search

ssec-jhu / evolver-ng

Next gen eVolver controller for bioreactor project - wip
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Refactor usage of creation pattern #53

Closed jamienoss closed 2 months ago

jamienoss commented 3 months ago

Cascade of #37

I.e., bulk out concrete __init__ with args (func sig) rather than just passing a single config.

jamienoss commented 3 months ago

@amitschang FYI, I'm going to do this now rather than parts of it being in #47

jamienoss commented 3 months ago

When I started doing this, it quickly occurred to me that we might not be using pedantic pydantically. Instead of writing normal python classes that have pydantic model configs, it would be more "pydanically correct" to just make all classes pydantic models.

@amitschang and I discussed this briefly offline and are in agreement.

I'm going to go ahead and do this now to resolve this issue as a lot of the creation code evaporates as we can fully leverage pydantic.

jamienoss commented 3 months ago

Well... actually maybe not, giving it another 2 sec of more thought, there's stuff, i.e., locks etc that might end up adding more work since not everything needs to be a part of the config.