ssec-jhu / evolver-ng

Next gen eVolver controller for bioreactor project - wip
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Post review changes to #74 #76

Closed jamienoss closed 2 months ago

jamienoss commented 2 months ago

Improvements to #74 Resolves #67

See https://github.com/ssec-jhu/evolver-ng/pull/74#issuecomment-2135456108

I think the files should rep descriptors not just the config such that the file also has the classinfo so that when looking at a config file you know what model it's for.

Also, we should note that pydantic has similar functionality for reading from files YamlConfigSettingsSource but isn't quite what we want.

jamienoss commented 2 months ago

@amitschang converted this back to a draft for a mo, whilst I sort out the tests and config file.