search

ssec-jhu / evolver-ng

Next gen eVolver controller for bioreactor project - wip
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add formatter #81

Closed ryanhausen closed 2 months ago

ryanhausen commented 2 months ago

This PR adds the ruff formatter to the project.

jamienoss commented 2 months ago

@ryanhausen thanks for doing this. I can take it from here though so that we don't merge this until after some larger existing PRs are merged to reduce significant conflict resolution.

@amitschang FYI

amitschang commented 2 months ago

@jamienoss ok, I will cease and desist. Another way is just to merge in (ignoring failures) the config parts of this. But I'll leave it to you

jamienoss commented 2 months ago

@amitschang Yep, we could merge in the formatted infra without the format changes, turn off the test, and then redo the broad formatting at a later time, but that's almost the same as holding off on this for a mo.

jamienoss commented 2 months ago

@amitschang I've rebased and rerun the formater. Ready for review again please, cheers.

Also, you cool with this getting merged now? I still have some PRs open that may be a pita to rebase but at least #73 is merged as that would have been very painful.

jamienoss commented 2 months ago

The formatting is automatable, so should not be too problematic

For sure, we can trivially run it for the new PRs to have them pass the new style test. I meant more about all of the changes introduced by this PR will cause conflicts with existing open PRs when rebasing.